Extract S3 code to Bucket #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmelt
requested changes
Oct 18, 2022
| rescue Aws::S3::Errors::NotFound | ||
| @rubys3_client.create_bucket(bucket: bucket) | ||
| end | ||
| Bucket.getClient.create_bucket(bucket) | ||
| s3_presigner = Aws::S3::Presigner.new |
| } | ||
| ) | ||
| end | ||
|
|
||
| def self.list_files_before_time(bucket, prefix, time) | ||
| rubys3_client = Aws::S3::Client.new |
There was a problem hiding this comment.
This file should be renamed to bucket_utilities and use Bucket.
Codecov ReportBase: 74.00% // Head: 74.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 74.00% 74.21% +0.20%
==========================================
Files 414 416 +2
Lines 25669 25667 -2
Branches 562 562
==========================================
+ Hits 18997 19048 +51
+ Misses 6586 6533 -53
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.