Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target logging, Streaming API cleanup, Improved Log Message Component #227

Merged
merged 25 commits into from
Nov 8, 2022

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Nov 2, 2022

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas November 2, 2022 00:29
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 74.87% // Head: 74.85% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e701979) compared to base (8be7851).
Patch coverage: 77.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   74.87%   74.85%   -0.02%     
==========================================
  Files         416      418       +2     
  Lines       25673    26245     +572     
  Branches      562      567       +5     
==========================================
+ Hits        19223    19647     +424     
- Misses       6364     6508     +144     
- Partials       86       90       +4     
Flag Coverage Δ
frontend 75.07% <72.41%> (-0.36%) ⬇️
ruby-api 46.75% <86.85%> (+2.62%) ⬆️
ruby-backend 79.61% <71.62%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/plugins/openc3-tool-base/src/openc3-tool-base.js 100.00% <ø> (ø)
...nit/plugins/packages/openc3-tool-admin/src/main.js 100.00% <ø> (ø)
...plugins/packages/openc3-tool-autonomic/src/main.js 100.00% <ø> (ø)
.../plugins/packages/openc3-tool-calendar/src/main.js 100.00% <ø> (ø)
...plugins/packages/openc3-tool-cmdsender/src/main.js 100.00% <ø> (ø)
...gins/packages/openc3-tool-cmdtlmserver/src/main.js 100.00% <ø> (ø)
...ins/packages/openc3-tool-dataextractor/src/main.js 100.00% <ø> (ø)
...lugins/packages/openc3-tool-dataviewer/src/main.js 100.00% <ø> (ø)
...ins/packages/openc3-tool-limitsmonitor/src/main.js 100.00% <ø> (ø)
...gins/packages/openc3-tool-packetviewer/src/main.js 100.00% <ø> (ø)
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas
Copy link
Member

jmthomas commented Nov 2, 2022

Looks like Data Extractor and Data Viewer don't like these changes (playwright).

@ryanmelt ryanmelt merged commit 7d4c57d into master Nov 8, 2022
@ryanmelt ryanmelt deleted the target_logging branch November 8, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants