Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate max notifications reached #238

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Indicate max notifications reached #238

merged 1 commit into from
Nov 7, 2022

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Nov 6, 2022

closes #118

@jmthomas jmthomas requested a review from ryanmelt November 6, 2022 14:21
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 74.18% // Head: 74.11% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (5d23428) compared to base (ad88bd2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   74.18%   74.11%   -0.07%     
==========================================
  Files         416      416              
  Lines       25665    25665              
  Branches      562      562              
==========================================
- Hits        19039    19022      -17     
- Misses       6543     6556      +13     
- Partials       83       87       +4     
Flag Coverage Δ
frontend 75.20% <ø> (-0.43%) ⬇️
ruby-api 44.04% <ø> (ø)
ruby-backend 78.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/tools/Autonomic/Tabs/Triggers/TriggerOperand.vue 60.00% <0.00%> (-16.00%) ⬇️
...enc3-tool-calendar/src/tools/Calendar/Calendar.vue 61.37% <0.00%> (-6.21%) ⬇️
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 70.90% <0.00%> (-0.89%) ⬇️
openc3/lib/openc3/utilities/metric.rb 96.07% <0.00%> (+5.88%) ⬆️
...tlmserver/src/tools/CmdTlmServer/InterfacesTab.vue 52.94% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 92c37c4 into master Nov 7, 2022
@jmthomas jmthomas deleted the notification_count branch November 7, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical notifications counter is limited to 100 without indication that more have occured
2 participants