Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for packets not received #240

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix for packets not received #240

merged 2 commits into from
Nov 7, 2022

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Nov 7, 2022

closes #215

@jmthomas jmthomas requested a review from ryanmelt November 7, 2022 01:15
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 74.18% // Head: 74.91% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (6894dd6) compared to base (ad88bd2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   74.18%   74.91%   +0.72%     
==========================================
  Files         416      416              
  Lines       25665    25673       +8     
  Branches      562      562              
==========================================
+ Hits        19039    19232     +193     
+ Misses       6543     6358     -185     
  Partials       83       83              
Flag Coverage Δ
ruby-api 44.12% <ø> (+0.08%) ⬆️
ruby-backend 79.70% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/script/api_shared.rb 87.17% <100.00%> (+44.45%) ⬆️
...nc3-script-runner-api/app/models/running_script.rb 19.77% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 4f4baa6 into master Nov 7, 2022
@jmthomas jmthomas deleted the wait_expressions branch November 7, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wait*() raises NoMethodError if no packets of the given type has ever arrived
1 participant