Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GEMS bucket. GemModel directly uses /gems volume instead #241

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Nov 8, 2022

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas November 8, 2022 20:52
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 74.92% // Head: 74.77% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (b775da0) compared to base (7d4c57d).
Patch coverage: 46.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   74.92%   74.77%   -0.16%     
==========================================
  Files         418      418              
  Lines       26240    26251      +11     
  Branches      562      567       +5     
==========================================
- Hits        19660    19628      -32     
- Misses       6494     6532      +38     
- Partials       86       91       +5     
Flag Coverage Δ
frontend 74.88% <ø> (-0.55%) ⬇️
ruby-api 46.72% <0.00%> (-0.03%) ⬇️
ruby-backend 79.53% <62.85%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nc3-cmd-tlm-api/app/controllers/gems_controller.rb 13.33% <0.00%> (-0.96%) ⬇️
openc3/lib/openc3/models/plugin_model.rb 87.58% <54.54%> (-2.01%) ⬇️
openc3/lib/openc3/models/gem_model.rb 68.96% <65.21%> (-18.34%) ⬇️
openc3/lib/openc3/utilities/local_mode.rb 100.00% <100.00%> (ø)
...enc3-tool-calendar/src/tools/Calendar/Calendar.vue 61.37% <0.00%> (-6.21%) ⬇️
...tlmserver/src/tools/CmdTlmServer/InterfacesTab.vue 47.05% <0.00%> (-5.89%) ⬇️
...tsmonitor/src/tools/LimitsMonitor/LimitsEvents.vue 76.47% <0.00%> (-5.89%) ⬇️
...xtractor/src/tools/DataExtractor/DataExtractor.vue 80.95% <0.00%> (-3.29%) ⬇️
...nit/plugins/packages/openc3-tool-admin/src/main.js 100.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit 5898b4f into master Nov 10, 2022
@ryanmelt ryanmelt deleted the remove_gems_bucket branch November 10, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants