Stash api #300
Stash api #300
Conversation
| stash_set('key2', 2) | ||
| check_expression("'#{stash_all().to_s}' == '{\"key1\"=>1, \"key2\"=>2}'") | ||
| stash_delete('key2') | ||
| check_expression("#{stash_get('key2').nil?} == true") |
There was a problem hiding this comment.
Add some examples of complex data types, not just strings and integers.
|
|
||
| require 'spec_helper' | ||
| require 'openc3/api/stash_api' | ||
|
|
There was a problem hiding this comment.
Add complex data types tests. Arrays, hashes, and nested versions.
| if (hash['start'] && hash['stop']) | ||
| hash['start'] = Time.parse(hash['start']).to_i | ||
| hash['stop'] = Time.parse(hash['stop']).to_i | ||
| json = @model_class.range(**hash.symbolize_keys, scope: params[:scope]) | ||
| json = @model_class.range(start: ['start'], stop: ['stop'], limit: limit, scope: params[:scope]) |
There was a problem hiding this comment.
Range takes start stop and limit ...
There was a problem hiding this comment.
I think you meant hash['start'], hash['stop'], not just ['start']
| message: e.message, | ||
| type: e.class, | ||
| }, | ||
| status: 409 # Conflict |
There was a problem hiding this comment.
Should this be 409. We're using that for Hazardous Error and probably should be exclusive.
There was a problem hiding this comment.
Ah right ... I wanted something to indicate the overlap because that is going to be a common error if you try to create two metadata entries back to back. Actually I see other controllers using 409 so I think that's a more common existing error. I think it's ok for Hazardous to remain 409 as it's unique to the commanding logic.
openc3/lib/openc3/api/stash_api.rb
Outdated
| authorize(permission: 'script_view', scope: scope, token: token) | ||
| result = StashModel.get(name: key, scope: scope) | ||
| if result | ||
| Marshal.load(result['value']) |
There was a problem hiding this comment.
Don't use Marshal. Use JSON. Marshal can only be used with Ruby code.
openc3/lib/openc3/api/stash_api.rb
Outdated
|
|
||
| def stash_all(scope: $openc3_scope, token: $openc3_token) | ||
| authorize(permission: 'script_view', scope: scope, token: token) | ||
| StashModel.all(scope: scope).transform_values { |hash| Marshal.load(hash["value"]) } |
closes #293