Multi microservice #311
Merged
Multi microservice #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
reviewed
Dec 6, 2022
| else | ||
| # Respawn regular microservice | ||
| @changed_microservices[microservice_name] = microservice_config | ||
| end | ||
| end |
There was a problem hiding this comment.
What's going on with all the re-parenting logic? How would this play out in a real system?
There was a problem hiding this comment.
Part of this change is the ability to break out microservices from the multi_microservice. This allows for scaling and isolation if necessary. There is no way currently to switch between two parents, but there are ways to go from having a parent, to not, and from not, to having a parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2-3x less RAM!
For the demo:
Operator reduced from 2.25GB to 850MB = 2.65X
Overall memory reduced from 2.7GB to 1.3GB = ~2.08X