Fix removed TIMEFORMATTED and ace build #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Dec 12, 2022
| @@ -16,7 +16,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@openc3/tool-common": "5.1.2-beta0", | |||
| "ace-builds": "1.13.2", | |||
| "ace-builds": "1.13.0", | |||
There was a problem hiding this comment.
Starting with 1.31.1 it doesn't render correctly: ajaxorg/ace#5012
Codecov ReportBase: 74.95% // Head: 74.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 74.95% 74.94% -0.01%
==========================================
Files 447 447
Lines 27145 27145
Branches 578 578
==========================================
- Hits 20347 20345 -2
- Misses 6707 6709 +2
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ryanmelt
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.