Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default command buffer depth to 5 #332

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas December 13, 2022 16:36
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 74.98% // Head: 75.02% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (e73e4d4) compared to base (626b5c6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   74.98%   75.02%   +0.03%     
==========================================
  Files         447      447              
  Lines       27166    27166              
  Branches      578      578              
==========================================
+ Hits        20371    20380       +9     
+ Misses       6703     6695       -8     
+ Partials       92       91       -1     
Flag Coverage Δ
frontend 75.77% <ø> (+0.18%) ⬆️
ruby-api 50.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/target_model.rb 70.57% <ø> (ø)
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 72.29% <0.00%> (+6.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more sensible default for commands

@ryanmelt ryanmelt merged commit 440da25 into main Dec 13, 2022
@ryanmelt ryanmelt deleted the cmd_buffer_depth_5 branch December 13, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants