Secrets, MQTT interface, interface & protocol cmds #347
Conversation
| other_interface.options = self.options.clone | ||
| self.options.each do |option_name, option_values| | ||
| other_interface.set_option(option_name, option_values) | ||
| end |
There was a problem hiding this comment.
Good change because serial_interface overrides set_option to do more
| result = protocol.protocol_cmd(cmd_name, @cmd_args) if index == protocol_index or index == -1 | ||
| handled = true if result | ||
| end | ||
| return handled |
There was a problem hiding this comment.
Default is every protocol gets the command and if any return non-nil (or false) it's considered handled. I don't see anyone using or caring about this return code and whether it was handled though.
| ENV['OPENC3_SECRET_BACKEND'] ||= 'redis' | ||
|
|
||
| module OpenC3 | ||
| class Secrets |
There was a problem hiding this comment.
I think this API will work well with the methods defined by https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/SecretsManager/Client.html
| if parameters[3] | ||
| # Option Name, Secret Name | ||
| @secret_options << [parameters[3], parameters[1]] | ||
| end |
There was a problem hiding this comment.
You can make this a secret and a secret option at the same time? What does that look like?
There was a problem hiding this comment.
See the example openc3-cosmos-mqtt-test plugin I added.
jmthomas
changed the title
|
closes #269 |
Codecov ReportBase: 74.98% // Head: 74.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 74.98% 74.71% -0.27%
==========================================
Files 446 450 +4
Lines 27187 27386 +199
Branches 578 578
==========================================
+ Hits 20385 20462 +77
- Misses 6709 6830 +121
- Partials 93 94 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…com/OpenC3/cosmos into secrets_and_interface_protocol_cmds
No description provided.