Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default PV rows to 20, max 1000, store choice to localStorage #379

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

jmthomas
Copy link
Member

closes #360

@jmthomas jmthomas requested a review from ryanmelt January 12, 2023 01:17
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 74.66% // Head: 74.69% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (fe49a94) compared to base (9678c1b).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   74.66%   74.69%   +0.02%     
==========================================
  Files         450      450              
  Lines       27427    27433       +6     
  Branches      583      584       +1     
==========================================
+ Hits        20479    20490      +11     
+ Misses       6857     6852       -5     
  Partials       91       91              
Flag Coverage Δ
frontend 75.74% <33.33%> (+0.13%) ⬆️
ruby-api 50.29% <ø> (ø)
ruby-backend 78.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cketviewer/src/tools/PacketViewer/PacketViewer.vue 88.05% <33.33%> (-5.39%) ⬇️
...tsmonitor/src/tools/LimitsMonitor/LimitsEvents.vue 77.77% <0.00%> (-5.56%) ⬇️
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 71.49% <0.00%> (+0.29%) ⬆️
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 72.29% <0.00%> (+6.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit ee78505 into main Jan 12, 2023
@jmthomas jmthomas deleted the packet_viewer_rows branch January 12, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for Packet Viewer to show all rows by default
2 participants