Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break out reducer microservice by default #439

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Feb 1, 2023

closes #409

@ryanmelt ryanmelt requested a review from jmthomas February 1, 2023 20:34
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you know this syntax better than I do

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 75.76% // Head: 74.79% // Decreases project coverage by -0.97% ⚠️

Coverage data is based on head (27d3174) compared to base (33f9eeb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   75.76%   74.79%   -0.97%     
==========================================
  Files         383      455      +72     
  Lines       25403    27689    +2286     
  Branches      592      592              
==========================================
+ Hits        19247    20711    +1464     
- Misses       6062     6884     +822     
  Partials       94       94              
Flag Coverage Δ
ruby-api 50.19% <ø> (+23.82%) ⬆️
ruby-backend 78.95% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/target_model.rb 73.84% <ø> (+3.26%) ⬆️
...os-cmd-tlm-api/app/controllers/notes_controller.rb 96.87% <0.00%> (ø)
...m-api/app/controllers/process_status_controller.rb 44.44% <0.00%> (ø)
...cosmos-cmd-tlm-api/app/models/config_events_api.rb 50.00% <0.00%> (ø)
...cmd-tlm-api/app/controllers/activity_controller.rb 77.46% <0.00%> (ø)
openc3-cosmos-cmd-tlm-api/app/models/screen.rb 33.33% <0.00%> (ø)
...-cmd-tlm-api/app/controllers/trigger_controller.rb 15.62% <0.00%> (ø)
...cmd-tlm-api/config/initializers/wrap_parameters.rb 100.00% <0.00%> (ø)
...-api/app/controllers/internal_status_controller.rb 83.33% <0.00%> (ø)
openc3-cosmos-cmd-tlm-api/config/application.rb 90.00% <0.00%> (ø)
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit ac9bd65 into main Feb 1, 2023
@ryanmelt ryanmelt deleted the breakout_reducer branch February 1, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seperate Reducer Microservice from Multi Microservice by default
2 participants