Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo microservices to inherit Microservice #440

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 1, 2023

closes #394

@jmthomas jmthomas requested a review from ryanmelt February 1, 2023 22:10
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 75.76% // Head: 74.71% // Decreases project coverage by -1.05% ⚠️

Coverage data is based on head (d8c78b9) compared to base (33f9eeb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   75.76%   74.71%   -1.05%     
==========================================
  Files         383      455      +72     
  Lines       25403    27689    +2286     
  Branches      592      592              
==========================================
+ Hits        19247    20689    +1442     
- Misses       6062     6905     +843     
- Partials       94       95       +1     
Flag Coverage Δ
frontend 76.05% <ø> (-0.07%) ⬇️
ruby-api 50.19% <ø> (+23.82%) ⬆️
ruby-backend 78.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlmserver/src/tools/CmdTlmServer/InterfacesTab.vue 47.05% <0.00%> (-5.89%) ⬇️
...md-tlm-api/app/channels/timeline_events_channel.rb 27.27% <0.00%> (ø)
...nc3-cosmos-cmd-tlm-api/config/initializers/cors.rb 100.00% <0.00%> (ø)
...pi/config/initializers/filter_parameter_logging.rb 100.00% <0.00%> (ø)
openc3-cosmos-cmd-tlm-api/config/application.rb 90.00% <0.00%> (ø)
...tlm-api/app/models/streaming_object_file_reader.rb 94.11% <0.00%> (ø)
.../app/controllers/microservice_status_controller.rb 75.00% <0.00%> (ø)
...-tlm-api/app/controllers/application_controller.rb 88.88% <0.00%> (ø)
...os-cmd-tlm-api/app/controllers/tools_controller.rb 26.08% <0.00%> (ø)
...os-cmd-tlm-api/app/controllers/notes_controller.rb 96.87% <0.00%> (ø)
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit 75a6255 into main Feb 1, 2023
@ryanmelt ryanmelt deleted the demo_microservice branch February 1, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo should extend microservice
2 participants