Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script overrides #450

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Script overrides #450

merged 4 commits into from
Feb 3, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 3, 2023

closes #371

@jmthomas jmthomas requested a review from ryanmelt February 3, 2023 20:37
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 74.48% // Head: 74.43% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (6e03bf3) compared to base (b347f2b).
Patch coverage: 54.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   74.48%   74.43%   -0.06%     
==========================================
  Files         457      458       +1     
  Lines       27898    27968      +70     
  Branches      592      592              
==========================================
+ Hits        20781    20818      +37     
- Misses       7022     7056      +34     
+ Partials       95       94       -1     
Flag Coverage Δ
frontend 75.74% <0.00%> (-0.37%) ⬇️
ruby-api 50.19% <ø> (ø)
ruby-backend 78.48% <79.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/tools/ScriptRunner/Dialogs/OverridesDialog.vue 0.00% <0.00%> (ø)
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 73.73% <0.00%> (-0.22%) ⬇️
openc3/lib/openc3/script/api_shared.rb 85.64% <40.00%> (ø)
openc3/lib/openc3/script/telemetry.rb 45.16% <52.63%> (+11.82%) ⬆️
openc3/lib/openc3/api/tlm_api.rb 98.81% <100.00%> (+0.02%) ⬆️
openc3/lib/openc3/models/cvt_model.rb 100.00% <100.00%> (ø)
openc3/lib/openc3/version.rb 100.00% <100.00%> (ø)
...smonitor/src/tools/LimitsMonitor/LimitsControl.vue 81.15% <0.00%> (-0.73%) ⬇️
...tlmserver/src/tools/CmdTlmServer/InterfacesTab.vue 52.94% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt
Copy link
Member

ryanmelt commented Feb 3, 2023

Need to fix ./spec/script/script_spec.rb:54

@jmthomas jmthomas merged commit d70d9fd into main Feb 3, 2023
@jmthomas jmthomas deleted the script_overrides branch February 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check overrides in Script Runner
2 participants