Improve Script running/completed scripts #469
Conversation
Codecov ReportBase: 74.44% // Head: 74.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 74.44% 74.54% +0.09%
==========================================
Files 458 458
Lines 27971 27982 +11
Branches 593 594 +1
==========================================
+ Hits 20824 20859 +35
+ Misses 7053 7028 -25
- Partials 94 95 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Playwright should pass once I merge the other PR into this |
| @@ -104,11 +104,12 @@ def get_target_file(path, original: false, scope: $openc3_scope) | |||
| if part == "targets_modified" and ENV['OPENC3_LOCAL_MODE'] | |||
| local_file = OpenC3::LocalMode.open_local_file(path, scope: scope) | |||
| if local_file | |||
| OpenC3::Logger.info "Reading local #{scope}/#{path}" | |||
There was a problem hiding this comment.
Do we want to log reading files?
There was a problem hiding this comment.
Yeah we're already doing it in the nominal case so we should in the local mode case
closes #465