-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data extractor updates #476
Conversation
…nager handle multiple workers. Apis multiple workers
Codecov ReportBase: 74.47% // Head: 74.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 74.47% 74.49% +0.02%
==========================================
Files 459 458 -1
Lines 28017 28036 +19
Branches 594 595 +1
==========================================
+ Hits 20865 20886 +21
+ Misses 7057 7054 -3
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -830,7 +844,8 @@ export default { | |||
} else { | |||
let rawVal = packet[key]['raw'] | |||
if (Array.isArray(rawVal)) { | |||
row[columnMap[key]] = '"[' + rawVal + ']"' | |||
// row[columnMap[key]] = '"[' + rawVal + ']"' | |||
row[columnMap[key]] = 'BINARY' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance I thought this was outputting ARRAY items but they don't come across with 'raw' right? How would you extract raw binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array items aren't raw. I'll write a ticket to get the JSON as an output.
return self.to_json_raw_object | ||
else | ||
return as_utf8 | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you run into this? Raw binary again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raw binary with just small numbers is what we put into the INST IMAGE
@@ -52,7 +52,7 @@ def start | |||
|
|||
# Spawns short lived processes and ensures they complete | |||
class ProcessManager | |||
MONITOR_CYCLE_SECONDS = 10 | |||
MONITOR_CYCLE_SECONDS = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.