Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data extractor updates #476

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Data extractor updates #476

merged 3 commits into from
Feb 14, 2023

Conversation

ryanmelt
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 74.47% // Head: 74.49% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9efcc4d) compared to base (59548f3).
Patch coverage: 85.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   74.47%   74.49%   +0.02%     
==========================================
  Files         459      458       -1     
  Lines       28017    28036      +19     
  Branches      594      595       +1     
==========================================
+ Hits        20865    20886      +21     
+ Misses       7057     7054       -3     
- Partials       95       96       +1     
Flag Coverage Δ
frontend 76.24% <93.10%> (+0.13%) ⬆️
ruby-api 50.08% <100.00%> (ø)
ruby-backend 78.46% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3-cosmos-cmd-tlm-api/config/application.rb 90.00% <ø> (ø)
openc3/lib/openc3/utilities/process_manager.rb 28.00% <20.00%> (-0.38%) ⬇️
...xtractor/src/tools/DataExtractor/DataExtractor.vue 81.38% <93.10%> (+1.46%) ⬆️
...-cmd-tlm-api/app/controllers/plugins_controller.rb 22.22% <100.00%> (+1.76%) ⬆️
...s-cmd-tlm-api/app/controllers/scopes_controller.rb 43.75% <100.00%> (+3.75%) ⬆️
openc3/lib/openc3/io/json_rpc.rb 55.95% <100.00%> (+0.69%) ⬆️
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 71.62% <0.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -830,7 +844,8 @@ export default {
} else {
let rawVal = packet[key]['raw']
if (Array.isArray(rawVal)) {
row[columnMap[key]] = '"[' + rawVal + ']"'
// row[columnMap[key]] = '"[' + rawVal + ']"'
row[columnMap[key]] = 'BINARY'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance I thought this was outputting ARRAY items but they don't come across with 'raw' right? How would you extract raw binary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array items aren't raw. I'll write a ticket to get the JSON as an output.

return self.to_json_raw_object
else
return as_utf8
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you run into this? Raw binary again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raw binary with just small numbers is what we put into the INST IMAGE

@@ -52,7 +52,7 @@ def start

# Spawns short lived processes and ensures they complete
class ProcessManager
MONITOR_CYCLE_SECONDS = 10
MONITOR_CYCLE_SECONDS = 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanmelt ryanmelt merged commit 3eeed1e into main Feb 14, 2023
@ryanmelt ryanmelt deleted the data_extractor_updates branch February 14, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants