Default various SETTINGS to px #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.51% // Head: 74.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 74.51% 74.48% -0.03%
==========================================
Files 458 458
Lines 28049 28049
Branches 596 596
==========================================
- Hits 20901 20893 -8
- Misses 7052 7060 +8
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ryanmelt
reviewed
Feb 16, 2023
| @@ -62,10 +62,16 @@ export default { | |||
| style['text-align'] = setting[1].toLowerCase() | |||
| break | |||
| case 'PADDING': | |||
| style['padding'] = setting[1] + 'px !important' | |||
| if (!isNaN(Number(setting[1]))) { | |||
There was a problem hiding this comment.
This is an interesting way of detecting mixed numbers and text.
ryanmelt
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #474