Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TlmGrapher improvements #508

Merged
merged 1 commit into from
Feb 22, 2023
Merged

TlmGrapher improvements #508

merged 1 commit into from
Feb 22, 2023

Conversation

ryanmelt
Copy link
Member

Removed immediate redraws on every data change. Add alive? check to handoff in streaming api.
Fixed changing items causing TlmGrapher to crash.

@ryanmelt ryanmelt requested a review from jmthomas February 22, 2023 19:48
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 73.97% // Head: 74.00% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (46a9d89) compared to base (dd689a1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   73.97%   74.00%   +0.03%     
==========================================
  Files         460      460              
  Lines       28322    28380      +58     
  Branches      596      596              
==========================================
+ Hits        20950    21004      +54     
- Misses       7275     7279       +4     
  Partials       97       97              
Flag Coverage Δ
ruby-backend 77.83% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nc3-cosmos-cmd-tlm-api/app/models/streaming_api.rb 91.11% <ø> (-0.10%) ⬇️
...-cosmos-cmd-tlm-api/app/models/streaming_object.rb 98.18% <ø> (-0.04%) ⬇️
...tlmgrapher/src/tools/TlmGrapher/SettingsDialog.vue 66.66% <ø> (ø)
...ool-tlmgrapher/src/tools/TlmGrapher/TlmGrapher.vue 43.44% <ø> (ø)
...nc3/lib/openc3/microservices/decom_microservice.rb 85.50% <0.00%> (-1.64%) ⬇️
openc3/lib/openc3/utilities/aws_bucket.rb 39.32% <0.00%> (-1.16%) ⬇️
openc3/lib/openc3/utilities/bucket_file_cache.rb 23.68% <0.00%> (-0.16%) ⬇️
...b/openc3/tools/table_manager/table_manager_core.rb 88.34% <0.00%> (-0.12%) ⬇️
openc3/lib/openc3/models/cvt_model.rb 100.00% <0.00%> (ø)
.../lib/openc3/microservices/reaction_microservice.rb 22.67% <0.00%> (+0.08%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit 80a97db into main Feb 22, 2023
@ryanmelt ryanmelt deleted the tlmgrapher_improvements branch February 22, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants