Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets update #516

Merged
merged 3 commits into from
Feb 26, 2023
Merged

Secrets update #516

merged 3 commits into from
Feb 26, 2023

Conversation

ryanmelt
Copy link
Member

Update secrets to support secret_store (for kubernetes secrets).
Also cleanup updateToken code

@ryanmelt ryanmelt requested a review from jmthomas February 26, 2023 06:47
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 73.97% // Head: 73.93% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (0d935dc) compared to base (d0fb720).
Patch coverage: 53.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   73.97%   73.93%   -0.05%     
==========================================
  Files         459      459              
  Lines       28423    28433      +10     
  Branches      597      599       +2     
==========================================
- Hits        21026    21021       -5     
- Misses       7300     7315      +15     
  Partials       97       97              
Flag Coverage Δ
frontend 75.50% <63.63%> (-0.20%) ⬇️
ruby-api 49.65% <ø> (ø)
ruby-backend 77.98% <47.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/interface_model.rb 90.76% <0.00%> (-0.95%) ⬇️
openc3/lib/openc3/models/microservice_model.rb 91.73% <0.00%> (-1.55%) ⬇️
...enc3/lib/openc3/operators/microservice_operator.rb 20.19% <0.00%> (ø)
...xtractor/src/tools/DataExtractor/DataExtractor.vue 81.00% <60.00%> (-0.52%) ⬇️
...ool-dataviewer/src/tools/DataViewer/DataViewer.vue 83.33% <66.66%> (-0.95%) ⬇️
openc3/lib/openc3/utilities/redis_secrets.rb 53.33% <100.00%> (ø)
openc3/lib/openc3/utilities/secrets.rb 66.66% <100.00%> (ø)
...rc/tools/Calendar/Dialogs/TimelineCreateDialog.vue 78.26% <0.00%> (-8.70%) ⬇️
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 68.70% <0.00%> (-3.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit a1e84e1 into main Feb 26, 2023
@ryanmelt ryanmelt deleted the secrets_update branch February 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant