Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker network to scripts #562

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

ryanmelt
Copy link
Member

closes #561

@ryanmelt ryanmelt requested a review from jmthomas March 27, 2023 22:17
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.22 🎉

Comparison is base (b5818f6) 73.90% compared to head (1d4fca2) 76.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   73.90%   76.12%   +2.22%     
==========================================
  Files         458      439      -19     
  Lines       28385    27109    -1276     
  Branches      590      590              
==========================================
- Hits        20978    20638     -340     
+ Misses       7314     6379     -935     
+ Partials       93       92       -1     
Flag Coverage Δ
frontend 74.77% <ø> (+0.04%) ⬆️
ruby-api 63.95% <ø> (+12.91%) ⬆️
ruby-backend 77.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

@ryanmelt
Copy link
Member Author

This allows the cli to interact with the other containers.

@jmthomas
Copy link
Member

This allows the cli to interact with the other containers.

Was the CLI broken in specific use cases?

@ryanmelt
Copy link
Member Author

I guess. See #561.

@ryanmelt ryanmelt merged commit 2d0d7a4 into main Mar 31, 2023
@ryanmelt ryanmelt deleted the add_docker_network_to_scripts branch March 31, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cli irb to the "openc3-cosmos-network"
2 participants