Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instrumentation #568

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Improve instrumentation #568

merged 1 commit into from
Apr 3, 2023

Conversation

ryanmelt
Copy link
Member

closes #560

@ryanmelt ryanmelt requested a review from jmthomas March 31, 2023 22:35
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 95.95% and project coverage change: +0.48 🎉

Comparison is base (a3222ba) 73.91% compared to head (8edb02d) 74.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   73.91%   74.40%   +0.48%     
==========================================
  Files         458      458              
  Lines       28399    28269     -130     
  Branches      590      590              
==========================================
+ Hits        20992    21034      +42     
+ Misses       7314     7143     -171     
+ Partials       93       92       -1     
Flag Coverage Δ
frontend 74.77% <ø> (+0.04%) ⬆️
ruby-api 51.03% <ø> (ø)
ruby-backend 78.65% <95.95%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/utilities/ruby_lex_utils.rb 96.04% <95.93%> (+53.69%) ⬆️
openc3/lib/openc3/models/plugin_model.rb 99.40% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really hard to see what the changes are due to the indentation changes removing the Ruby 2.7 check but looks like a really nice improvement.

@ryanmelt ryanmelt merged commit 9cb9459 into main Apr 3, 2023
@ryanmelt ryanmelt deleted the improve_instrumentation branch April 3, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script runner hash table limitations
2 participants