Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate built gem #577

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Validate built gem #577

merged 3 commits into from
Apr 4, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 1, 2023

Not sure if this is the best way to do this but seems like we can call validate using the cli in the Rakefile. This worked when I ran it on a regular project but obviously you'd have to have those scripts in your path. I tried it in the demo project and got this: Error: You don't have write permissions for the /usr/lib/ruby/gems/3.1.0 directory.

@jmthomas jmthomas requested a review from ryanmelt April 1, 2023 14:04
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.48 🎉

Comparison is base (a3222ba) 73.91% compared to head (78dbac2) 74.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   73.91%   74.39%   +0.48%     
==========================================
  Files         458      458              
  Lines       28399    28269     -130     
  Branches      590      590              
==========================================
+ Hits        20992    21032      +40     
+ Misses       7314     7144     -170     
  Partials       93       93              
Flag Coverage Δ
ruby-api 51.03% <ø> (ø)
ruby-backend 78.65% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/plugin_model.rb 99.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 3d63698 into main Apr 4, 2023
@jmthomas jmthomas deleted the validate_build branch April 4, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant