Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run_script #591

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix run_script #591

merged 2 commits into from
Apr 12, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 7, 2023

closes #586

@jmthomas jmthomas requested a review from ryanmelt April 7, 2023 00:17
@jmthomas
Copy link
Member Author

jmthomas commented Apr 7, 2023

Added playwright test to specifically check for this: OpenC3/cosmos-playwright@154e2d9

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 6.25% and no project coverage change.

Comparison is base (8eb694e) 74.41% compared to head (d5e791b) 74.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         458      458           
  Lines       28270    28276    +6     
  Branches      590      590           
=======================================
+ Hits        21037    21042    +5     
  Misses       7140     7140           
- Partials       93       94    +1     
Flag Coverage Δ
frontend 74.93% <ø> (+0.10%) ⬆️
ruby-api 51.02% <0.00%> (-0.02%) ⬇️
ruby-backend 78.62% <7.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mos-script-runner-api/app/models/running_script.rb 19.85% <0.00%> (-0.03%) ⬇️
openc3/lib/openc3/script/script_runner.rb 20.00% <7.69%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 8408eac into main Apr 12, 2023
@jmthomas jmthomas deleted the run_script branch April 12, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

script_run() fails
2 participants