Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move limits set to LimitsMonitor and fix limitsbar #606

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

jmthomas
Copy link
Member

closes #570

@jmthomas jmthomas requested a review from ryanmelt April 13, 2023 19:05
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.05 🎉

Comparison is base (8408eac) 74.38% compared to head (0a3c06e) 74.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   74.38%   74.44%   +0.05%     
==========================================
  Files         458      457       -1     
  Lines       28274    28263      -11     
  Branches      590      587       -3     
==========================================
+ Hits        21033    21039       +6     
+ Misses       7147     7131      -16     
+ Partials       94       93       -1     
Flag Coverage Δ
frontend 75.07% <86.66%> (+0.28%) ⬆️
ruby-api 51.02% <ø> (ø)
ruby-backend 78.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...smonitor/src/tools/LimitsMonitor/LimitsControl.vue 84.35% <ø> (+1.36%) ⬆️
...smonitor/src/tools/LimitsMonitor/LimitsMonitor.vue 79.31% <86.66%> (+7.88%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit c96795a into main Apr 14, 2023
@jmthomas jmthomas deleted the limits_set branch April 14, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move limits set selection to Limits Monitor
2 participants