Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace edit json dialog and redis #608

Merged
merged 5 commits into from
Apr 15, 2023
Merged

Ace edit json dialog and redis #608

merged 5 commits into from
Apr 15, 2023

Conversation

jmthomas
Copy link
Member

closes #583

@jmthomas jmthomas requested a review from ryanmelt April 14, 2023 04:57
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (d4a8e96) 74.41% compared to head (5823710) 74.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   74.41%   74.48%   +0.07%     
==========================================
  Files         458      457       -1     
  Lines       28262    28270       +8     
  Branches      589      588       -1     
==========================================
+ Hits        21031    21057      +26     
+ Misses       7137     7120      -17     
+ Partials       94       93       -1     
Flag Coverage Δ
frontend 75.16% <100.00%> (+0.41%) ⬆️
ruby-api 51.02% <ø> (ø)
ruby-backend 78.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 69.72% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

:readonly="readonly"
data-test="editTextInput"
/>
<pre id="editor"></pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using id is going to cause us problems eventually if we do the split screen. Is there any way to not use id, or give it a unique id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you can select the element yourself and give it to the ace constructor. I'll see if I can make that work and update EditScreenDialog and ScriptRunner as well.

@jmthomas jmthomas merged commit 637647b into main Apr 15, 2023
@jmthomas jmthomas deleted the monospace branch April 15, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monospace font where appropriate
2 participants