-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ace edit json dialog and redis #608
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 74.41% 74.48% +0.07%
==========================================
Files 458 457 -1
Lines 28262 28270 +8
Branches 589 588 -1
==========================================
+ Hits 21031 21057 +26
+ Misses 7137 7120 -17
+ Partials 94 93 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
:readonly="readonly" | ||
data-test="editTextInput" | ||
/> | ||
<pre id="editor"></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using id is going to cause us problems eventually if we do the split screen. Is there any way to not use id, or give it a unique id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think you can select the element yourself and give it to the ace constructor. I'll see if I can make that work and update EditScreenDialog and ScriptRunner as well.
closes #583