Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix target_index in packet log writer #617

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix target_index in packet log writer #617

merged 1 commit into from
Apr 17, 2023

Conversation

ryanmelt
Copy link
Member

target_index was incorrectly incrementing with each new log file created by the same PacketLogWriter rendering it invalid.

@ryanmelt ryanmelt requested a review from jmthomas April 17, 2023 01:50
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.08 ⚠️

Comparison is base (a78b55f) 74.35% compared to head (5e75ecc) 74.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   74.35%   74.28%   -0.08%     
==========================================
  Files         460      460              
  Lines       28541    28546       +5     
  Branches      588      588              
==========================================
- Hits        21222    21205      -17     
- Misses       7226     7247      +21     
- Partials       93       94       +1     
Flag Coverage Δ
frontend 74.70% <ø> (-0.40%) ⬇️
ruby-api 50.96% <ø> (ø)
ruby-backend 78.44% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/logs/packet_log_reader.rb 89.02% <25.00%> (-1.61%) ⬇️
openc3/lib/openc3/logs/packet_log_writer.rb 99.01% <100.00%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new test case!

@ryanmelt ryanmelt merged commit 56316d9 into main Apr 17, 2023
@ryanmelt ryanmelt deleted the fix_target_index branch April 17, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants