-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope updates #63
Scope updates #63
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,6 +255,8 @@ export default { | |
'openc3-tool-tablemanager', | ||
'openc3-tool-tlmgrapher', | ||
'openc3-tool-tlmviewer', | ||
'openc3-enterprise-tool-base', | ||
'openc3-enterprise-tool-admin', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think these should be here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The alternative is copy this whole file into enterprise and then add in the differences, or come up with some sort of included subfile. This is the simplest for now and we can cleanup later. |
||
], | ||
} | ||
}, | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird to have to give a scope: 'DEFAULT' to the process to destroy scopes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DEFAULT scope is also going to be the kindof "global scope" that owns Scopes and Roles.