Limits monitor layout issues #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 74.48% 74.53% +0.04%
==========================================
Files 462 462
Lines 28669 28668 -1
Branches 588 588
==========================================
+ Hits 21354 21367 +13
+ Misses 7221 7209 -12
+ Partials 94 92 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This reverts commit 80cc71e.
jmthomas
commented
Apr 25, 2023
| ['WIDTH', '520px'], // Total of three subwidgets | ||
| ['0', 'WIDTH', '180px'], | ||
| ['1', 'WIDTH', '180px'], | ||
| ['2', 'WIDTH', '160px'], | ||
| ['__SCREEN__', this], |
There was a problem hiding this comment.
Explicitly setting the WIDTH of the overall widget prevents the weird line wrapping
| :parameters="parameters" | ||
| :settings="[...settings]" | ||
| :widget-index="1" | ||
| /> |
There was a problem hiding this comment.
The rule is that any composition widget must set the widget-index.
ryanmelt
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.