Interface modifiers and other fixes #656
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
- Coverage 74.43% 74.38% -0.06%
==========================================
Files 464 464
Lines 28577 28599 +22
Branches 575 575
==========================================
+ Hits 21271 21273 +2
- Misses 7217 7237 +20
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| else | ||
| yield line, true, inside_begin, lex.exp_line_no | ||
| end | ||
| yield line, true, inside_begin, lex.exp_line_no |
There was a problem hiding this comment.
What were you trying to accomplish with these two blocks that got removed?
There was a problem hiding this comment.
They handled cases that now appear to be handled by paying attention to ltype.
| @@ -699,6 +699,8 @@ def set_min_max_default(item, type, data_type) | |||
| # Strip quotes from strings | |||
| if type.initialValue[0] == '"' && type.initialValue[-1] == '"' | |||
| item.default = type.initialValue[1..-2] | |||
| else | |||
| item.default = type.initialValue | |||
There was a problem hiding this comment.
Apparently. Someone ran into this case in COSMOS 4.
| @@ -65,7 +65,7 @@ def _generate_auth | |||
|
|
|||
| def _request(*method_params, **kw_params) | |||
| kw_params[:scope] = $openc3_scope unless kw_params[:scope] | |||
| kw_params[:json] => true unless kw_params[:json] | |||
| kw_params[:json] = true unless kw_params[:json] | |||
There was a problem hiding this comment.
This previously looks like a syntax error. Not even sure what this does. Did you look for other examples?
There was a problem hiding this comment.
It was a bug for sure. Setting the json flag adds the appropriate content-type header.
closes #653
closes #627