Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix layout, default 0px margin #673

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix matrix layout, default 0px margin #673

merged 1 commit into from
May 22, 2023

Conversation

jmthomas
Copy link
Member

closes #668

@jmthomas jmthomas requested a review from ryanmelt May 19, 2023 13:19
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (3bf6d9c) 74.77% compared to head (b566193) 74.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   74.77%   74.75%   -0.03%     
==========================================
  Files         454      455       +1     
  Lines       28412    28428      +16     
  Branches      545      545              
==========================================
+ Hits        21244    21250       +6     
- Misses       7084     7095      +11     
+ Partials       84       83       -1     
Flag Coverage Δ
frontend 77.48% <ø> (-0.14%) ⬇️
ruby-api 51.31% <ø> (-0.06%) ⬇️
ruby-backend 78.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 7d90f5c into main May 22, 2023
@jmthomas jmthomas deleted the matrix branch May 22, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MATRIXBYCOLUMNS not aligning fields
2 participants