Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitsbar show no yellow if yellow == red #718

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Limitsbar show no yellow if yellow == red #718

merged 1 commit into from
Jun 30, 2023

Conversation

jmthomas
Copy link
Member

closes #717

@jmthomas jmthomas requested a review from ryanmelt June 29, 2023 05:03
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b5e4c9) 72.76% compared to head (fd99a14) 72.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files         470      470           
  Lines       30589    30589           
  Branches      889      889           
=======================================
+ Hits        22257    22258    +1     
+ Misses       8240     8239    -1     
  Partials       92       92           
Flag Coverage Δ
frontend 60.08% <ø> (+0.01%) ⬆️
ruby-api 50.85% <ø> (ø)
ruby-backend 80.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit d63dd94 into main Jun 30, 2023
@jmthomas jmthomas deleted the limits_bar branch June 30, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LimitsBar doesn't support yellow == red limits
2 participants