Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add directive code byte to data length #6

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Add directive code byte to data length #6

merged 9 commits into from
Nov 22, 2023

Conversation

ryanmelt
Copy link
Member

closes #5

@ryanmelt ryanmelt requested a review from jmthomas November 14, 2023 05:27
@ryanmelt ryanmelt mentioned this pull request Nov 14, 2023
Closed
jmthomas
jmthomas reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped the dependencies while we're at it. I'm surprised that you didn't have to change any of the unit tests for this change. Seems like the playwright test is broken too.

@ryanmelt ryanmelt merged commit 322f08a into main Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmthomas jmthomas jmthomas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Directive PDU data length field is off by 1
2 participants
@ryanmelt @jmthomas