Scope updates #63
Scope updates #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 77.77% 77.73% -0.05%
==========================================
Files 238 238
Lines 18555 18575 +20
==========================================
+ Hits 14432 14439 +7
- Misses 4123 4136 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| def destroy | ||
| return unless authorization('superadmin') | ||
| begin | ||
| result = OpenC3::ProcessManager.instance.spawn(["ruby", "/openc3/bin/openc3cli", "destroyscope", params[:id]], "scope_uninstall", params[:id], Time.now + 2.hours, scope: 'DEFAULT') |
There was a problem hiding this comment.
Seems weird to have to give a scope: 'DEFAULT' to the process to destroy scopes
There was a problem hiding this comment.
The DEFAULT scope is also going to be the kindof "global scope" that owns Scopes and Roles.
| @@ -255,6 +255,8 @@ export default { | |||
| 'openc3-tool-tablemanager', | |||
| 'openc3-tool-tlmgrapher', | |||
| 'openc3-tool-tlmviewer', | |||
| 'openc3-enterprise-tool-base', | |||
| 'openc3-enterprise-tool-admin', | |||
There was a problem hiding this comment.
I don't think these should be here
There was a problem hiding this comment.
The alternative is copy this whole file into enterprise and then add in the differences, or come up with some sort of included subfile. This is the simplest for now and we can cleanup later.
Updates to make scopes work as desired.