Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] add ability to validate draft and ingest it back through worker (#6577) #8659

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Oct 14, 2024

Proposed changes

  • add the ability to validate a draft: draft content is sent as a bundle to worker to ingest it back into live platform
  • add operation metadata on draft entities: draft entities can be created in the draft, updated in the draft or deleted in the draft
  • add the ability to delete in draft: deleted entities in draft are no longer visible in the platform unless the option to include deleted draft element is specified
  • add the ability to revert a change in draft

PR linked on client-python: OpenCTI-Platform/client-python#753

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@labo-flg labo-flg force-pushed the release/6.4.0 branch 2 times, most recently from c150d0f to 264e053 Compare October 15, 2024 20:34
@JeremyCloarec JeremyCloarec force-pushed the issue/6577chunk4 branch 2 times, most recently from 209b52c to 2c40e9c Compare October 21, 2024 14:56
@JeremyCloarec JeremyCloarec changed the title Issue/6577chunk4 [backend] add ability to validate draft and ingest it back through worker Oct 22, 2024
@JeremyCloarec JeremyCloarec added the multi-repository For contribution that requires PR in several repository label Oct 25, 2024
@JeremyCloarec JeremyCloarec force-pushed the issue/6577chunk4 branch 2 times, most recently from 1589c14 to bae3e81 Compare October 28, 2024 13:37
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 58.13953% with 108 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (99deaea) to head (8efb0b6).
Report is 1 commits behind head on release/6.4.0.

Files with missing lines Patch % Lines
...ti-platform/opencti-graphql/src/database/engine.js 23.37% 59 Missing ⚠️
...latform/opencti-graphql/src/database/middleware.js 25.00% 18 Missing ⚠️
...modules/draftWorkspace/draftWorkspace-connector.ts 75.51% 12 Missing ⚠️
opencti-platform/opencti-graphql/src/managers.js 0.00% 10 Missing ⚠️
...ti-platform/opencti-graphql/src/http/httpServer.js 0.00% 3 Missing ⚠️
...rc/modules/draftWorkspace/draftWorkspace-domain.ts 92.30% 3 Missing ⚠️
...atform/opencti-graphql/src/database/draft-utils.js 90.00% 2 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/work.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8659      +/-   ##
=================================================
+ Coverage          64.33%   64.37%   +0.04%     
=================================================
  Files                608      609       +1     
  Lines              58054    58286     +232     
  Branches            6408     6439      +31     
=================================================
+ Hits               37348    37523     +175     
- Misses             20706    20763      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec added multi-repository For contribution that requires PR in several repository and removed multi-repository For contribution that requires PR in several repository labels Oct 30, 2024
@JeremyCloarec JeremyCloarec force-pushed the issue/6577chunk4 branch 4 times, most recently from 5833f5d to 43058fa Compare October 31, 2024 12:08
@SouadHadjiat SouadHadjiat changed the title [backend] add ability to validate draft and ingest it back through worker [backend] add ability to validate draft and ingest it back through worker (#6577) Oct 31, 2024
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Oct 31, 2024
@JeremyCloarec JeremyCloarec marked this pull request as ready for review October 31, 2024 14:53
@JeremyCloarec JeremyCloarec removed the multi-repository For contribution that requires PR in several repository label Nov 4, 2024
@JeremyCloarec JeremyCloarec force-pushed the issue/6577chunk4 branch 2 times, most recently from d1e6fa9 to 89d72d6 Compare November 5, 2024 16:17
@JeremyCloarec JeremyCloarec merged commit 0a608c0 into release/6.4.0 Nov 6, 2024
5 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/6577chunk4 branch November 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants