Modernize Eigen3, GLEW and OpenGL use as imported targets #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen3 is a header only template library, adopt an updated FindEigen.cmake that creates an imported target. Note that include directories from imported targets are automatically treated as system includes on compilers that support the concept. The core header only Avogadro library exposes it as part of its interface, and then we are able to remove a huge amount of duplicated code. Still need to look at the other side to ensure the exported targets find all targets like Eigen they depend upon. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
We can migrate to the CMake version that provides imported target, and stop carrying around our own version now that our CMake minimum has been bumped. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Remove a bunch of unused/duplicated CMake calls, and use the new imported targets for GLEW and OpenGL. Also add Avogadro::Headers to the Avogadro::Rendering public interface. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
cryos
changed the title
Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
|
Looks like the wheel builds are failing due to use of older Cmake: |
|
Thanks, I am going to look at the wheels in a separate PR, but I wanted to separate that work out. The cibuildwheel needs updating quite a bit as do the Python versions. |
|
Here are the build results |
|
Here are the build results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eigen3 is a header only template library, adopt an updated FindEigen.cmake that creates an imported target. Note that include directories from imported targets are automatically treated as system includes on compilers that support the concept.
The core header only Avogadro library exposes it as part of its interface, and then we are able to remove a huge amount of duplicated code. Still need to look at the other side to ensure the exported targets find all targets like Eigen they depend upon.