Skip to content

Commit

Permalink
Remove packages and package_dir from setup.py
Browse files Browse the repository at this point in the history
I really am not sure why, but this has been causing big headaches for
use with scikit build. Probably some hard-to-track bug.

Basically, if we kept these lines the way that they are, all of the
targets `install()`ed by cmake get installed in a completely different
location than the rest of the packages. They get installed in "stempy"
in the root directory of the environment instead of inside
lib/pythonX.X/site-packages/stempy. I really don't know why, but since
we can seemingly do things fine without those lines, just remove them.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
  • Loading branch information
psavery committed Feb 19, 2021
1 parent ca0b6c6 commit 1a9e0cd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ def extra_cmake_args():
'Programming Language :: Python :: 3',
],
keywords='',
packages=['stempy', 'stempy.io', 'stempy.image', 'stempy.pipeline'],
package_dir={'':'python'},
packages=['stempy'],
install_requires=[
'numpy',
'h5py',
Expand Down

0 comments on commit 1a9e0cd

Please sign in to comment.