Avoid ENOBUFS OSErrors by shrinking the size of SNDBUF when appropriate. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
requested changes
Jul 7, 2022
pavel-kirienko
approved these changes
Jul 7, 2022
|
@wiboticalex can you please run Black to fix the formatting? This should get merged automatically afterward. |
auto-merge was automatically disabled
July 7, 2022 17:30
Head branch was pushed to by a user without write access
|
Done. Thought I could get away with moving code around and not reformatting, but apparently not 🙂 . Thanks @pavel-kirienko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to issue #233.
Avoid ENOBUFS OSErrors by shrinking the size of SNDBUF when appropriate.
Similar behavior could have probably been achieved by simply setting the socket's SNDBUF to 0 to get whatever Linux sets as the minimum, but it seems like this may cause potential queue under-utilization when there are large queues specified, so this pull request tries to calculate (with a very rough approximation for sk_buffer struct size) what the minimum SNDBUF should be to get blocking behavior.