-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 259 - Create GH Actions workflow to replace AppVeyor #303
Conversation
935eb98
to
061e38e
Compare
061e38e
to
a3ef9e0
Compare
I have tested the PYPI_TEST_API_TOKEN_GLOBAL token on the Note: The GHA workflow will fail to deploy until the pycyphal version number is incremented. |
The pull request event was added to the workflow as requested. |
95f4887
to
4e7d224
Compare
Note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the workflow file so that the name indicates that it also runs the test suite aside from publishing the release?
9e5ef75
to
e0de6f3
Compare
a07f49c
to
818e030
Compare
818e030
to
7b36beb
Compare
Sonar and Coveralls are now working. This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but please confirm that the exit status is not ignored on Windows (this issue has been observed in Yakut). Feel free to merge after this is verified/addressed. Thanks!
This PR addresses issue #259 to move the AppVeyor workflow to GH Actions. Some differences:
Important: The Windows self-hosted runners differ from the GH Actions runners in that they are not rebuilt after each workflow run. Therefore, there is a chance the Windows runners could become corrupted. A clean installation of the Windows runners can be made from AWS Images if required.