Cyphal/UDP: remove the default local_node_id #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
requested changes
May 3, 2024
pycyphal/transport/udp/_udp.py
Outdated
| @@ -64,7 +64,7 @@ class UDPTransport(pycyphal.transport.Transport): | |||
| def __init__( | |||
| self, | |||
| local_ip_address: IPAddress | str, | |||
| local_node_id: typing.Optional[int] = 0, | |||
| local_node_id: typing.Optional[int] = None, | |||
There was a problem hiding this comment.
Suggested change
| local_node_id: typing.Optional[int] = None, | |
| local_node_id: typing.Optional[int], |
I originally wrote None in the issue but then realized that the default should be absent for consistency with the other transports, and updated the issue accordingly.
There was a problem hiding this comment.
should I bump version to 1.18.1?
pavel-kirienko
changed the title
pavel-kirienko
changed the title
|
Please also fix the failed test affected by this change |
|
(history rewrite is not necessary because all commits will be squashed upon merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #323