Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socketcan timestamp on newer 32 bit kernel #341

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

tomasjakubik
Copy link
Contributor

Kernel now defines old and new SO_TIMESTAMP and can send both of them in ancillary data.

Kernel now defines old and new SO_TIMESTAMP and can send both of them in
ancillary data.
@tomasjakubik
Copy link
Contributor Author

I am not sure why the Test stage got skipped 🤷. But I think that this fix would not get covered by any tests anyway.
🙏 Please review.

Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the workflow was skipped either. GitHub Actions are being weird lately.

@@ -1 +1 @@
__version__ = "1.19.0"
__version__ = "1.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, since this is a fix, can you please bump the patch version instead?

@pavel-kirienko pavel-kirienko enabled auto-merge (squash) June 19, 2024 07:38
@coveralls
Copy link

Coverage Status

coverage: 94.689% (-0.09%) from 94.777%
when pulling 99c409d on tomasjakubik:fix-timeval
into 4df7d14 on OpenCyphal:master.

@pavel-kirienko pavel-kirienko merged commit d232fc1 into OpenCyphal:master Jun 19, 2024
10 checks passed
@tomasjakubik tomasjakubik deleted the fix-timeval branch June 19, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants