Skip to content

Commit

Permalink
perf stat: Revert checks for duration_time
Browse files Browse the repository at this point in the history
This reverts e864c5c ("perf stat: Hide internal duration_time
counter") but doing it manually since the code has now moved to a
different file.

The next patch will properly implement duration_time as a full event, so
no need to hide it anymore.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20190326221823.11518-2-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Andi Kleen authored and acmel committed Apr 1, 2019
1 parent 7fcfa9a commit c2b3c17
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions tools/perf/util/stat-display.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
#define CNTR_NOT_SUPPORTED "<not supported>"
#define CNTR_NOT_COUNTED "<not counted>"

static bool is_duration_time(struct perf_evsel *evsel)
{
return !strcmp(evsel->name, "duration_time");
}

static void print_running(struct perf_stat_config *config,
u64 run, u64 ena)
{
Expand Down Expand Up @@ -628,9 +623,6 @@ static void print_aggr(struct perf_stat_config *config,
ad.id = id = config->aggr_map->map[s];
first = true;
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;

ad.val = ad.ena = ad.run = 0;
ad.nr = 0;
if (!collect_data(config, counter, aggr_cb, &ad))
Expand Down Expand Up @@ -848,8 +840,6 @@ static void print_no_aggr_metric(struct perf_stat_config *config,
if (prefix)
fputs(prefix, config->output);
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;
if (first) {
aggr_printout(config, counter, cpu, 0);
first = false;
Expand Down Expand Up @@ -906,8 +896,6 @@ static void print_metric_headers(struct perf_stat_config *config,

/* Print metrics headers only */
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;
os.evsel = counter;
out.ctx = &os;
out.print_metric = print_metric_header;
Expand Down Expand Up @@ -1136,15 +1124,11 @@ perf_evlist__print_counters(struct perf_evlist *evlist,
break;
case AGGR_THREAD:
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;
print_aggr_thread(config, _target, counter, prefix);
}
break;
case AGGR_GLOBAL:
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;
print_counter_aggr(config, counter, prefix);
}
if (metric_only)
Expand All @@ -1155,8 +1139,6 @@ perf_evlist__print_counters(struct perf_evlist *evlist,
print_no_aggr_metric(config, evlist, prefix);
else {
evlist__for_each_entry(evlist, counter) {
if (is_duration_time(counter))
continue;
print_counter(config, counter, prefix);
}
}
Expand Down

0 comments on commit c2b3c17

Please sign in to comment.