LCD info display corrections and date format tweak #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be going from kilowatts to megawatts, not milliwatts. All units above 'k' should be capital letters.
This is unambiguous to interpret in all parts of the world, including the US, UK, and Europe.
| @@ -546,7 +546,7 @@ void LcdTask::displayInfoLine(LcdInfoLine line, unsigned long &nextUpdate) | |||
| gettimeofday(&local_time, NULL); | |||
| struct tm timeinfo; | |||
| localtime_r(&local_time.tv_sec, &timeinfo); | |||
| strftime(temp, sizeof(temp), "%d/%m/%Y", &timeinfo); | |||
There was a problem hiding this comment.
I think this is more of a personal taste/country specific convention, so should probably handle separately, probably needs to be user configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric units fix here should be uncontroversial- we need to be using
MWh, notmWh, to be megawatt-hours, not milliwatt-hours. https://en.wikipedia.org/wiki/Metric_prefix#List_of_SI_prefixesThe date one might be a bit less desired, but I'd advocate for making the change. The OpenEVSE web UI has the advantage of being able to use the browser/OS date format, but the LCD display format is hardcoded. By using the ISO date format, there should be no confusion with a date such as "04/07/2022" - is this April 7th (as a US resident would likely interpret it), or July 4th (as most of the rest of the world would use)? By displaying "2022-07-04", it is much less ambiguous.