-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current shaper module #382
Conversation
Does the max power need to be a feed? Would it not be a fixed value? |
not really for my use case. |
latest commit seems functional. I've tested it for few hours, from another branch merged with my mqtt mods. |
I think we have everything needed to do the web UI parts now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, will give it a test
I've added the UI part. There's a pull request on the gui repo too: OpenEVSE/openevse_wifi_gui#79 |
I don't get why it says it has conflicts with the static files here. |
you can test booth mqtt mods and shaper merged on this branch if needed : |
There have just been some updates to the GUI so you need to merge |
missed those, thanks. |
b5f1325
to
e36e5e2
Compare
should be ok now |
you need first to get the gui pull request OpenEVSE/openevse_wifi_gui#79 to make it compile on the CI/CD |
Hiya, can you merge master into this and the GUI? I will fix the GUI ref after merging this PR |
Seems I've messed up with my git. I need to cleanup |
Yeah, was about to say something has gone very wrong ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need additional APIs for enabling/disabling the shaper, this can entirely be done via the config. To my mind it is a safety feature so should be setup and enabled then left. I don't think it should have the same MQTT/HTTP APIs to 'easily' switch on/off from external sources that the divert mode does, but other than that I think this is looking really good, will do some testing , hopefully tomorrow.
Looks good now |
Ok fair enough.
…On Fri, Jul 29, 2022, 7:07 PM Guillaume S ***@***.***> wrote:
Looks good now
I don't think we need additional APIs for enabling/disabling the shaper,
this can entirely be done via the config. To my mind it is a safety feature
so should be setup and enabled then left. I don't think it should have the
same MQTT/HTTP APIs to 'easily' switch on/off from external sources that
the divert mode does, but other than that I think this is looking really
good, will do some testing , hopefully tomorrow.
I have some use case where it's needed. Sometime I override the shaper to
let the car having max priority on my house load. Then the house heaters
are shaping the current instead.
Therefore, I've made a quick live switch to override it without writing in
the config.
—
Reply to this email directly, view it on GitHub
<#382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOVNAEF7JZTH4V25Q6FEA3VWQMWBANCNFSM5ZUCJURA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
If there was only a single claim that didn't set the state the EVSE manager would not defalut to active, this was only done when there where no claims. This was not a problem for previous modes that always set the state one way or another but for the current shaper it only sets the current and does not set the state, so if it is the only mode in operation and it switched off the charge it would not recover untill something else activated the charge.
I have tested this and it looks to work well. I did find a bug in the EVSE Manager when the current sharper was the only claim, and have pushed a fix. |
Current Shaper Class WIP
configuration:
mqtt_live_pwr : mqtt topic for instantaneous power taken from the grid
current_shaper_max_pwr : max power you can get from your energy plan in Watts
Fixes #65