Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few fixes #454

Merged
merged 10 commits into from
Nov 5, 2022
Merged

Few fixes #454

merged 10 commits into from
Nov 5, 2022

Conversation

KipK
Copy link
Collaborator

@KipK KipK commented Oct 24, 2022

some minor changes.

docs/user-guide.md Show resolved Hide resolved
src/web_server.cpp Outdated Show resolved Hide resolved
src/web_server.cpp Outdated Show resolved Hide resolved
src/web_server_claims.cpp Outdated Show resolved Hide resolved
@jeremypoulter
Copy link
Collaborator

jeremypoulter commented Oct 24, 2022

/claims returns 200 with an empty array when no claims are set. We can also add a claim_version to the status, same as the schedule if you need an event to update the claims, but the 404 is expected and the correct response in those cases.

@KipK
Copy link
Collaborator Author

KipK commented Oct 24, 2022

/claims returns 200 with an empty array when no claims are set. We can also add a claim_version to the status, same as the schedule if you need an event to update the claims, but the 404 is expected and the correct response in those cases.

ho I see, I'm calling /claims/{id} from the UI to only get the claim from Manual clientid.
I can solve that by grabing the whole package.

@KipK
Copy link
Collaborator Author

KipK commented Oct 24, 2022

a claim_version in status could be usefull yes

@jeremypoulter jeremypoulter changed the title Fewfixes Allow HTTP POST to update some status fields Nov 5, 2022
@jeremypoulter jeremypoulter changed the title Allow HTTP POST to update some status fields Few fixes Nov 5, 2022
@jeremypoulter jeremypoulter merged commit c1c9a8e into OpenEVSE:master Nov 5, 2022
@KipK KipK deleted the fewfixes branch November 21, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants