-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divert mode updates #76
Conversation
jeremypoulter
commented
May 3, 2020
- Stop charging when solar PV stops generating #54 Stop charging when solar generation stops
- Store config as JSON, including fix for Custom NTP Server hostname not saving #72
…ons in th esimulator or later be updated via MQTT feed
… into divert_mode_off
… into divert_mode_off
Fantastic. #67 has now been merged. @jeremypoulter Is it possible to fix the merge conflicts? |
Will do, been doing some preparations (moving some shared code to libraries) for backporting to the ESP8266. Wil fix the conflicts after this. |
Great, let me know when you're ready. It would be good to have a catchup chat after this PR is ready to merge and I've had a chance to test. Cheers |
Merged with Master and fixed a few other issues. This probably needs a really good test as the config sub-system has changed. |
Nice, after a minor issue with the Tesla code I got it compiled and uploaded. On HTTP update all the old EEPROM settings were lost and the unit dropped off the WiFi. I was able to get it reconnected easily by connecting to AP and entering my wifi details, all the config is now reverted to default settings. Was the expected? It's not the end of the world, this is a significant update. I'm sure we could persuade users to enter in their details again. I will continue to test and will report back.. |
User setting should be preserved on update, I added the code to do this so will check on that. (but not Tesla client options) |
Thanks. I've just tried to compile the latest version but I'm having an issue with ConfigJson, I'm getting error Any ideas? Full output:
|
Also I can't seem to enable solar pv divert, the eco toggle seems to be missing?! Nice work on the setup UI, the solar pv config settings look good. |
Re ConfigJson, Platform IO being slow. Looks to have picked up the new release now. I changed the UI to remove the switch, just enabling and setting up has the same effect as switching to eco mode |
Cool, it's working now I should have guessed.
How will the user enable / disable EcoMode? I've setup the MQTT feed for solar PV but it's still charging at full 32A.I think we need a toggle on the main page to enable / disable the feature. |
I've just tested the latest update by flashing the master branch then upgrading back to this PR and this time the config successfully transferred over 👍 Following on from our chat this afternoon I've tried to mock up the change to the UI I proposed. I'm keen to make it clear to the user what mode the EVSE is in and make it possible to easily disable Eco from the main page. As we mentioned before once Eco mode is enabled it should be pervasive between charging sessions. |
- Added charge_mode to dnamically enable/disable divert mode - events are now distributed internally using the parsed JsonDocument stops (badly) generating JSON docs as strings and (badly) parsing them to send out the various interfaces - extra debug info is now evented from the divert module - Typo fix
@glynhudson the last changes should be in now, think this is ready for final testing and merging |