Rename PACKED macro to SOEM_PACKED to avoid collision with fmtlib #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an unfortunate collision between SOEM and [fmtlib](https://github.com/fmtlib/fmt), where SOEM's definition of a `PACKED` macro collides with a [template parameter in fmtlib](https://github.com/fmtlib/fmt/blob/92cdbbae06fe43f87a6c59eb1d623bb5abc8405d/include/fmt/base.h#L1649). This causes some rather inscrutable compile errors, and isn't handled by the existing `#ifndef` check as fmtlib's usage is not a macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an unfortunate collision between SOEM and fmtlib, where SOEM's definition of a
PACKEDmacro collides with a template parameter in fmtlib.This causes some rather inscrutable compile errors, and isn't handled by the existing
#ifndefcheck as fmtlib's usage is not a macro.