ATL fix for verbs provider and some minor fixes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashoodk
requested changes
Oct 22, 2021
src/fam_atl.cpp
Outdated
| @@ -69,7 +69,7 @@ namespace openfam { | |||
| #define RETURN_WITH_FAM_EXCEPTION \ | |||
| } \ | |||
| catch (Fam_Exception & e) { \ | |||
| throw e; \ | |||
| throw e; \ | |||
There was a problem hiding this comment.
Is the spacing right ? Why is this line modified ?
| @@ -501,8 +501,8 @@ int atl_finalize() { | |||
|
|
|||
| if (serverAddrName) free(serverAddrName); | |||
|
|
|||
| if (defaultCtx != NULL) | |||
| delete defaultCtx; | |||
| //if (defaultCtx != NULL) | |||
There was a problem hiding this comment.
Can you add a TODO comment on why this is commented out ?
src/fam_atl.cpp
Outdated
| @@ -599,10 +599,11 @@ int fam_get_atomic(void *local, Fam_Descriptor *descriptor, | |||
|
|
|||
| uint64_t nodeId = descriptor->get_memserver_id(); | |||
| Fam_Context *ATLCtx = get_defaultCtx(nodeId); | |||
| //uint64_t ATLBaseAddr = (uint64_t)descriptor->get_base_address(); | |||
There was a problem hiding this comment.
Commented code,please remove
test/fam_SG_ATL.cpp
Outdated
| try { | ||
| myatlib->fam_scatter_atomic(msg1, item1, 5, 1, 2, 2); | ||
| } catch (Fam_Exception &e) { | ||
| cout << "Scatter atomic not found" << e.fam_error_msg() << endl; |
There was a problem hiding this comment.
correct the print message
test/fam_SG_ATL.cpp
Outdated
| @@ -164,6 +191,9 @@ int main() { | |||
| memset(msg2, 0, 200); | |||
| start = std::chrono::high_resolution_clock::now(); | |||
| myatlib->fam_gather_atomic(msg2, item1, 5, indexes, 2); | |||
| } catch (Fam_Exception &e) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATL Fix for Scale out System and fixes for #3 & #4