Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAST.Farm #2053

Closed
ILDENIEL opened this issue Feb 25, 2024 · 10 comments · Fixed by #2121 or #2474
Closed

FAST.Farm #2053

ILDENIEL opened this issue Feb 25, 2024 · 10 comments · Fixed by #2121 or #2474
Labels
Compiler: Intel FAST.Farm Type: Bug Type: Question
Milestone
v3.5.4

Comments

@ILDENIEL
Copy link

ILDENIEL commented Feb 25, 2024 •
edited
Loading

Hello everyone,
I'm trying to run FAST.Farm but an error occurred.
Before downloading the newest version I've used version 3.4.1 and FF ran without any problem.
image

OpenFAST v3.5.2 runs smoothly as always, what could be the problem?
Thanks in advance
@ILDENIEL
Copy link
Author

For compliteness
#2010 (comment)
At this link it is possible to find the problems with the previous version of FAST.Farm. For this reason I tried with FF v3.5.2.

@jjonkman
Copy link
Collaborator

Dear @ILDENIEL,

I'm not sure I understand. Are you saying a FAST.Farm model that runs without issue in OpenFAST v3.4.1 triggers a stack overflow error when running in OpenFAST v3.5.2? If so, can you share the full set of input files for both versions? If not, please clarify.

Best regards,

@ILDENIEL
Copy link
Author

Dear @jjonkman,
Yes this is what I meant.
In this folder you can find all the files I'm using, in particular

  • in the folder 341 you can find the fst, fstf and iw files for version v3.4.1
  • in the folder 352 you can find the fst, fstf and iw files for version v3.5.2
  • in the other folder there're all the ED,AD and IW files.

versions.zip

Thanks for your support.

@andrew-platt andrew-platt added this to the v3.5.3 milestone Feb 27, 2024
@andrew-platt
Copy link
Collaborator

Thanks for the set of input files. @jjonkman confirmed that it isn't an obvious configuration issue, so there is a bug in the code someplace causing the stack overflow. I will take a look at it and report what I figure out.

@ILDENIEL
Copy link
Author

Thank you for your support @andrew-platt @jjonkman,
I will continue using FF v3.4.1 for now.
Best regards

@yangpy88
Copy link

It seems like version 3.5.1 does not have this problem, but 3.5.0 and 3.5.2 have. Just FYI.

@deslaughter deslaughter mentioned this issue Mar 26, 2024
Merged
@andrew-platt
Copy link
Collaborator

We think this is fixed with #2118. Please reopen if you have issues with v3.5.3 (will be posted later this week).

@andrew-platt andrew-platt linked a pull request Mar 26, 2024 that will close this issue
Release 3.5.3 #2121
Merged
27 tasks
@jjonkman jjonkman mentioned this issue Mar 29, 2024
Closed
@andrew-platt
Copy link
Collaborator

This apparently was not fixed with #2118 as the issue still exists in the 3.5.3 release.

@andrew-platt andrew-platt reopened this May 14, 2024
@andrew-platt andrew-platt mentioned this issue May 15, 2024
Closed
@andrew-platt andrew-platt modified the milestones: v3.5.3, v3.5.4 Jun 18, 2024
@771217832
Copy link

771217832 commented Jun 26, 2024 •
edited
Loading

My dear
I had the same stack overflow issue(https://forums.nrel.gov/t/fast-farm/1887/484) with a low wind speed wind farm calculation ,and i fixed the issue by rolling back the Fast.farm version to 3.4.1
Best regards
Farm.zip

andrew-platt added a commit to andrew-platt/openfast that referenced this issue Oct 8, 2024
@andrew-platt
Intel builds: add /heap-arrays:1000 compile flag
dde75b8 
We have been having issues with stack overflows in FAST.Farm when large
wind grids were passed to AWAE.  This was eventually tracked down to
line 1078 in AWAE.f90 which reads:
`m%u_IfW_Low%PositionXYZ = p%Grid_low`
The `p%Grid_low` is of unknown size at compile time, but can be
extremely large (3x160000 or more).  This copy involves a temporary
array and would normally be handled on the stack, but could result in
an overflow for some models.  By setting the `/heap-arrays:1000` any
operation resulting in a temporary array of unknown array size at
compile time will use the heap for the temprary array, and as will any
array known at compile time to be larger than 1000 kB.

Testing shows that this fixes issue OpenFAST#2053, and will likely also solve OpenFAST#843 and OpenFAST#2241

See
https://www.intel.com/content/www/us/en/docs/fortran-compiler/developer-guide-reference/2024-2/heap-arrays.html
for reference.
@andrew-platt andrew-platt mentioned this issue Oct 8, 2024
Merged
@andrew-platt
Copy link
Collaborator

This should now be fixed with #2452. Closing this issue for now (we can reopen again if necessary).

@andrew-platt andrew-platt mentioned this issue Oct 21, 2024
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compiler: Intel FAST.Farm Type: Bug Type: Question
Projects
None yet
Milestone
v3.5.4
Development

Successfully merging a pull request may close this issue.

Release 3.5.3 OpenFAST/openfast
Release 3.5.4 OpenFAST/openfast
5 participants
@andrew-platt @jjonkman @yangpy88 @ILDENIEL @771217832