Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OLAF] Twist Not Computed in OLAF cases when Polar Projection is used, resulting in wrong Fn, Ft outputs #2348

Closed
ebranlard opened this issue Jul 27, 2024 · 1 comment
Closed

[OLAF] Twist Not Computed in OLAF cases when Polar Projection is used, resulting in wrong Fn, Ft outputs #2348

ebranlard opened this issue Jul 27, 2024 · 1 comment
Assignees
@ebranlard
Labels
Module: AeroDyn Type: Bug
Milestone
v4.0.0

Comments

@ebranlard
Copy link
Contributor

Bug description
The output variable PitchAndTwist is used to compute Fn, Ft, Cn, Ct, and Theta.
It's taken from thetaBladeNds, but thetaBladeNds is not defined when we use the polar BEM projection.

Below the following line, we should compute the twist.
(https://github.com/OpenFAST/openfast/blob/dev/modules/aerodyn/src/AeroDyn.f90#L3570)

I'll submit a pull request shortly.

OpenFAST Version
Current dev
@ebranlard ebranlard added this to the v4.0.0 milestone Jul 27, 2024
@ebranlard ebranlard self-assigned this Jul 27, 2024
ebranlard added a commit to ebranlard/openfast that referenced this issue Jul 27, 2024
@ebranlard
OLAF: Bug Fix twist not computed and wrong Fn (OpenFAST#2348)
4430e82
@ebranlard ebranlard mentioned this issue Jul 27, 2024
Merged
ebranlard added a commit to ebranlard/openfast that referenced this issue Jul 27, 2024
@ebranlard
OLAF: Bug Fix twist not computed and wrong Fn (OpenFAST#2348)
f08c4e8
@andrew-platt
Copy link
Collaborator

Fixed with #2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebranlard ebranlard

Labels
Module: AeroDyn Type: Bug
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@ebranlard @andrew-platt