-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinSock2.h needed for Windows build of MAP and this is not available in current SDKs #5
Labels
Comments
Can no longer reproduce. Closing until others report this as an issue with Windows builds of MAP++ |
ghost
mentioned this issue
Apr 16, 2019
Closed
andrew-platt
referenced
this issue
in andrew-platt/openfast
Mar 19, 2020
Thanks for doing this. We might want to update the write function in the future as well.
Closed
deslaughter
pushed a commit
to deslaughter/openfast
that referenced
this issue
Sep 1, 2022
Merge OpenFAST/dev + HD/SeaSt code cleanup
andrew-platt
pushed a commit
that referenced
this issue
Jan 10, 2024
mayankchetan
pushed a commit
to mayankchetan/openfast
that referenced
this issue
May 21, 2024
…kaging Move poetry files into distribution root and rename package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should include WinSock2.h in modules-ext/map/src to avoid compiling issues on Windows for people who only have the current Windows SDK on their machine or whose $(WindowsSDK_IncludePath) variable points to an SDK more recent than 7.1a.
I've fixed this on a Windows box by simply adding the path to the 7.1a include dir for my build box, i.e., C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include, in the MAP_dll project properties under VC++ Directories -> Include Directories.
But if we simply add WinSock2.h to the MAP_dll project, then the above fix is not needed and this solution would be valid for all Windows builds. We would need to exclude WinSock2.h from non-Windows builds.
The text was updated successfully, but these errors were encountered: