Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinSock2.h needed for Windows build of MAP and this is not available in current SDKs #5

Closed
HaymanConsulting opened this issue Jan 10, 2017 · 1 comment

Comments

@HaymanConsulting
Copy link
Contributor

We should include WinSock2.h in modules-ext/map/src to avoid compiling issues on Windows for people who only have the current Windows SDK on their machine or whose $(WindowsSDK_IncludePath) variable points to an SDK more recent than 7.1a.

I've fixed this on a Windows box by simply adding the path to the 7.1a include dir for my build box, i.e., C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include, in the MAP_dll project properties under VC++ Directories -> Include Directories.

But if we simply add WinSock2.h to the MAP_dll project, then the above fix is not needed and this solution would be valid for all Windows builds. We would need to exclude WinSock2.h from non-Windows builds.

@HaymanConsulting HaymanConsulting self-assigned this Jan 10, 2017
ghost referenced this issue in rafmudaf/openfast Aug 8, 2017
@HaymanConsulting
Copy link
Contributor Author

Can no longer reproduce. Closing until others report this as an issue with Windows builds of MAP++

bjonkman referenced this issue in bjonkman/openfast Jul 19, 2019
andrew-platt referenced this issue in andrew-platt/openfast Mar 19, 2020
Thanks for doing this. We might want to update the write function in the future as well.
andrew-platt added a commit that referenced this issue Jul 31, 2020
andrew-platt pushed a commit that referenced this issue Jul 31, 2020
deslaughter pushed a commit to deslaughter/openfast that referenced this issue Sep 1, 2022
Merge OpenFAST/dev + HD/SeaSt code cleanup
mayankchetan pushed a commit to mayankchetan/openfast that referenced this issue May 21, 2024
…kaging

Move poetry files into distribution root and rename package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants